-
-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
discuss: enabling categories on all endpoints #1405
Comments
Hi there and Happy New Year 😄 I think that for those who know this feature, it's already too late, we cannot do breaking changes or delete categories. The use of categories bypass placeholder, this gives some strange responses when we compare a query with and without the query parameter.
/v1/search?categories=&text=paris
At this time, there are no repositories containing all the categories, each repository create its own categories without a superior authority/global taxonomy. This could introduce mistakes (or not). The counter argument would be that users will not be able to add their own. I found something else, there are no categories for My last thought is : the categories need a bit more work before seeing the daylight 😅. |
Yeah at the moment there is no 'canonical list' of categories as such. |
Having this feature properly documented would be super valuable! |
related implementation for reverse: #1662, pelias/documentation#287 |
Worth noting: the existing categories 'predicates' assume that only documents from the While this may be true for canonical sources/layers this might not be the case for custom data. |
Issue #1401 brought up the topic of whether we should enable the
categories
feature by default across all endpoints.Currently, we have support for categories which goes back to 2015.
The feature consists of a single elasticsearch field with strings analyzed as
keyword
, so it's very simple but can also be very powerful for industry and interest-specific queries.When we went to release the feature there was some concern internally at Mapzen about the default taxonomy labels I had selected and the WOF team was preparing an improved list, this work unfortunately never got finished and so the feature was left in an awkward state of half-release, available, yet also hidden from view.
Over the years we've had a bunch of issues and PRs opened regarding
categories
and the theme seems to be that organizations find them useful.What would be required to completely release categories as a first-class feature?
Are there any concerns regarding the release of categories?
This ticket is open to discuss the pros/cons of enabling the categories feature by default and think through the work which would be required if we decided to go down that route.
cc/ @pelias/contributors
The text was updated successfully, but these errors were encountered: