Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate internals to immutable types #31

Open
pgte opened this issue Dec 8, 2018 · 1 comment
Open

migrate internals to immutable types #31

pgte opened this issue Dec 8, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@pgte
Copy link
Collaborator

pgte commented Dec 8, 2018

A CRDT type is defined in a stateless manner. All return values are supposed to be immutable, and there's a lot of cloning happening just to make sure we don't mutate past state.
Instead of that, I think we could have better performance (and less error-prone) if we used immutable types internally.

@pgte pgte added the enhancement New feature or request label Dec 8, 2018
@robchristian
Copy link

robchristian commented Nov 26, 2019

Looks like immutable is already in use. Strongly suggest the use of immer instead. Immutability is important, but immutable.js was a train wreck.
https://immerjs.github.io/immer/docs/introduction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants