Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grayscale Tiff rejected #10

Open
evansf opened this issue May 15, 2024 · 2 comments
Open

Grayscale Tiff rejected #10

evansf opened this issue May 15, 2024 · 2 comments

Comments

@evansf
Copy link

evansf commented May 15, 2024

THANKS! for the TileSource! It solves an issue for me and I appreciate your work!
But.....Attempting to view a grayscale tiled pyramidal tiff file, it was rejected at each tile because the ImageData type returned from class Converters is wrong. This type is determined by the buffer instantiation in the class Converters. This bug exists in multiple data type routines. In addition, the code in several class Converters methods iterate the output buffer incorrectly. These bugs affects multiple methods in class Converters. I have included source for GeoTiffTileSource.js (renamed .txt) that corrects these errors. I have tested it with my grayscale file but I have not tested the other file types for which I have edited in this correction. I leave it to you to make the adjustments for next release.
GeoTIFFTileSource.txt

@pearcetm
Copy link
Owner

Thanks for noticing this @evansf and for the suggested fixes. Those look reasonable to me, so I've gone ahead and created and merged PR #11

@pearcetm
Copy link
Owner

@evansf Has #11 fixed things for you, or are there more issues you've noticed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants