Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non regular files break cp even if they are excluded #775

Open
MqllR opened this issue Dec 10, 2024 · 0 comments · May be fixed by #776
Open

Non regular files break cp even if they are excluded #775

MqllR opened this issue Dec 10, 2024 · 0 comments · May be fixed by #776

Comments

@MqllR
Copy link

MqllR commented Dec 10, 2024

If a non-regular file exists in a directory and we try to cp, s5cmd will exit with an error. This is true even if we exclude that non-regular file.

Example:

ls -la /tmp/test/
total 172
drwxrwxr-x  4 mql  mql    4096 Dec 10 14:01 .
drwxrwxrwt 26 root root 159744 Dec 10 14:02 ..
drwx------  5 mql  root   4096 Dec 10 14:01 geth
srw-------  1 mql  root      0 Dec 10 14:01 geth.ipc
drwx------  2 mql  root   4096 Dec 10 14:01 keystore

Then cp:

s5cmd cp --exclude "*.ipc" /tmp/test/ s3://mybucket/
ERROR "cp --exclude=*.ipc /tmp/test/ s3://mybucket/": object '/tmp/test/geth.ipc' is not a regular file
cp ...

Expected behavior is that s5cmd won't consider this unix socket file.

@MqllR MqllR linked a pull request Dec 10, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant