-
-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: default github_token
to github.token
#624
base: main
Are you sure you want to change the base?
Conversation
Thank you for the work. This pull-request fixes #309 |
Codecov Report
@@ Coverage Diff @@
## main #624 +/- ##
=======================================
Coverage 61.73% 61.73%
=======================================
Files 4 4
Lines 277 277
Branches 49 49
=======================================
Hits 171 171
Misses 105 105
Partials 1 1
Continue to review full report at Codecov.
|
@peaceiris I think this one can be merged? |
I have added #309 to the v4 milestone. Since it takes a long time to publish, I will investigate this first from the viewpoint of backward compatibility, then try to merge this into the v3 line. 👍 |
@peaceiris this PR is backwards compatible, as the action now defaults to |
Not enough. We need to consider the source code. Perhaps, 631dd15 enables backward compatibility. |
I understand this change is not backwards compatible because of the case where users are using AFAIK, using a PAT or GITHUB_TOKEN is interchangeable (just different permissions). Would it be possible to eventually consolidate these two inputs into a |
Could we promote this? |
Permission was wrong in the first place, waiting for peaceiris/actions-gh-pages#624 to be merged to update the version of the action.
Permission was wrong in the first place, waiting for peaceiris/actions-gh-pages#624 to be merged to update the version of the action.
Fixes #309