-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vendor directory to AppStore build/release #65
Labels
Type: QA
Issues regarding the quality of the code and application
Comments
This was referenced Jan 2, 2022
The latests release(s) have been verified to have the Leaving this issue open until #64 has been resolved. |
Potherca
added
the
Type: QA
Issues regarding the quality of the code and application
label
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Several users that install the Solid-Nextcloud app throuch the NC App Store run into issues caused by the
vendor
directory not being present. As users should not have to run composer themselves, thevendor
directory needs to be part of the packaged release.Looking at how other packages do this (for instance user_oidc and mail) the most straightforward way of doing this seems to be a combination of using GitHub Actions and krankerl.
In order to have this setup correctly, the package release needs to be automated (see #64), so this can be added as part of the automation.
The text was updated successfully, but these errors were encountered: