-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colors match when they should not #986
Comments
Yeah there's a chance, I think I didn't handle the collision case. Open to reviewing a PR if you have any ideas though! |
I was trying to see if I could tinker with the color generation but it's crazy! Note to those who want to try this, the color generation is in I saw this comment in the code and it gave me a good chuckle: // crap! convert
var color = Raphael.color(fill);
fill = 'hsb(' + String(color.h) + ',' + String(color.l);
fill = fill + ',' + String(color.s) + ')'; I'm new to open source but I'd love to contribute to this project! I'm just a little confused since the colors get converted and blended so much lol |
First of all, incredible work here. A fantastic web app for learning Git.
It looks like colors may be randomly rendered for examples to distinguish one branch from another. However, sometimes the same color is rendered for different branches:
The text was updated successfully, but these errors were encountered: