-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility issues #960
Comments
Thanks for writing this up 😇 I think this application would need a lot of accessibility work beyond even what you mentioned -- we should probably generate alt text for the tree visualization in a way that is concise but understandable as well. It's a pretty large amount of scope but I'm supportive of folks putting up PR's for this! |
Part of pcottle#960.
Part of pcottle#960.
Some PRs have been created with some points solved (i guess) :
Done with #1022
Done with #1023. I haven't tried VoiceOver (or equivalent) yet. |
I think aria labels would be a lot safer in terms of browser support |
Done with #1030 |
Is anyone working on improvements "for people with low vision or color vision deficiency"? If not, I would like to take care of that :) |
I'm actually colorblind myself! I'm only the most common colorblind (red/green) so I haven't had any major issues using the application. Color isn't terribly important in our case, it's mostly just a visual aid to show which branches correspond to which commits. I think the other accessibility issues above are more important / pressing. |
Alright! I then would love to have a go on one of them! Oh I missed it was fixed already with #1030. I will take a look into sth else then :) Update: I am quite busy atm. I am still taking a look from time to time but do not want to block work on this. If I manage to come up with sth. you will see the pull request |
Hi!
I tried using macOS VoiceOver to navigate https://learngitbranching.js.org/ and noticed some accessibility issues:
display: none
or so when not visible)textarea
doesn't have a label.<dialog>.showModal()
could help (or maybe theinert
attribute).helperBarMount
could be a<nav>
).git status
), the resulting text that appears in the terminal should be read (it can be a live region, e.g.<output>
). Compare with how VoiceOver works in the macOS Terminal app.git commit
), the change should be announced (with a live region, or maybe as additional text in the terminal output).For people with low vision or color vision deficiency:
You can hide this window with "hide goal"
".The text was updated successfully, but these errors were encountered: