Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make (at least) 2 separate crates #26

Closed
4 tasks done
pchampin opened this issue Dec 12, 2019 · 1 comment
Closed
4 tasks done

Make (at least) 2 separate crates #26

pchampin opened this issue Dec 12, 2019 · 1 comment
Assignees
@pchampin

Comments

@pchampin
Copy link
Owner

pchampin commented Dec 12, 2019 •
edited
Loading

At the very least

  • sophia_api containing the basic types and generic traits
  • sophia depending on the former, and containing everything else
  • change the licence of sophia_api to a more permissive one (Apache or BSD?)
  • Later, I might split the remaining sophia crate into more fine-grained crates...

NB: this issue was created following the discussion at #23 (comment)
@pchampin pchampin self-assigned this Dec 12, 2019
This was referenced Dec 13, 2019
Closed
Closed
@pchampin pchampin mentioned this issue Dec 16, 2019
Closed
@MattesWhite MattesWhite mentioned this issue Jan 15, 2020
Closed
pchampin added a commit that referenced this issue Mar 19, 2020
@pchampin
Separate sophia_term as an autonomous crate
10f14c3 
This is a first step towards #26.

This change required a few minor adjustments,
mostly to remove cyclic dependencies,
between sophia_term and some other parts of sophia.

Apart from those, the API is unchanged,
and the sophia crate re-exports all public entities from sophia_term,
so that projects using sophia should not be impacted by this refactoring.
pchampin added a commit that referenced this issue Jul 16, 2020
@pchampin
Move all core traits and types in sophia_api.
1b328de 
This contributes to issues #23 and #26.
@pchampin
Copy link
Owner Author

pchampin commented Dec 4, 2023

should have been closed a long time ago

@pchampin pchampin closed this as completed Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pchampin pchampin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pchampin