Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: save pre-configured filters #59

Open
tangkong opened this issue Jul 18, 2024 · 1 comment
Open

ENH: save pre-configured filters #59

tangkong opened this issue Jul 18, 2024 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@tangkong
Copy link
Contributor

Current Behavior

There are no filters or ways to save them

Expected Behavior

I thought it might be nice to save filters. If we give the users a way to build complex search terms, we shouldn't require them to re-input them every time.

Context / environment

Ideated in #56

Steps to Reproduce (for bugs)

N/A

Suggested Solution

Filter definition

Filters could probably get by with minimal metadata (name, description, filter-contents)
Filter contents should be json compatible / plain text. We'll have to build some way to parse them, possibly within the Client
Possible something as simple as

filter_name: {filter_desc: desc,  kwarg: value, kwarg2: value2, ...}

Filter storage

We could store these in the config file, though this would require a plain-text / json interpretation of the search query. Plain text is probably most compatible, without this we'll have to switch the config format to something more complex than ini (toml?)
Maybe the config file points to some filter storage location.

@tangkong
Copy link
Contributor Author

My vision for this involves also filtering the global tree and showing only the matching entries. We'll probably have to wrap the existing RootTree model with an FilterProxyModel to do this, though it should be simple in implementation

@tangkong tangkong added this to the Beta Release milestone Jul 26, 2024
@tangkong tangkong added the enhancement New feature or request label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant