Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undocumented pragma delimiter semicolon (";") can be confusing #306

Open
klauer opened this issue May 9, 2023 · 0 comments
Open

Undocumented pragma delimiter semicolon (";") can be confusing #306

klauer opened this issue May 9, 2023 · 0 comments

Comments

@klauer
Copy link
Contributor

klauer commented May 9, 2023

; is treated the same as newlines in pragmas. This can trip up users, for example in:
pcdshub/lcls-twincat-general#73

Source:

pytmc/pytmc/pragmas.py

Line 20 in 434a8ea

_LINE_FINDER = re.compile(r"(?P<line>.+?)(?P<delim>(?:[;\n\r]+|$))")

I wouldn't be against deprecating it for the long-term, but short-term there should at least be a prominent note in the docs somewhere
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@klauer