Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TPR trigger channel, top level object, screens #1119

Closed
slactjohnson opened this issue Feb 22, 2023 · 4 comments
Closed

TPR trigger channel, top level object, screens #1119

slactjohnson opened this issue Feb 22, 2023 · 4 comments
Assignees

Comments

@slactjohnson
Copy link
Contributor

Current Behavior

We don't have anything for the TPR.

Expected Behavior

We should have support for the TPR equivalent to that of the EVR.

Context / environment

I have numerous devices that will require TPRs soon. So will lots of other people.

Suggested Solution

We should provide support equal to what is described in #1118 for the TPR.

There's also a question of how do we deal with timing changing sources? Maybe this is done in the IOC and we don't have to worry? I haven't inspected the TPR IOC yet, and have only briefly played with one, so I don't quite know how this should be done yet. Bruce's EDM screens currently allow you to choose what type of timing you're using, and the screen updates appropriately. We will eventually need the same functionality in PyDM and the TPR class.

/end confused rambling

@slactjohnson slactjohnson self-assigned this Oct 20, 2023
@ZLLentz
Copy link
Member

ZLLentz commented Oct 25, 2023

Requested again by James in https://jira.slac.stanford.edu/browse/ECS-3903

@ZLLentz
Copy link
Member

ZLLentz commented Oct 25, 2023

Adding Kaushik to match the Jira assignment

@KaushikMalapati KaushikMalapati mentioned this issue Oct 27, 2023
7 tasks
@slactjohnson
Copy link
Contributor Author

@KaushikMalapati can we close this now? I think your PR has been merged, right?

@KaushikMalapati
Copy link
Contributor

@KaushikMalapati can we close this now? I think your PR has been merged, right?

It has been, #1178.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants