Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RIX paths don't match reality #183

Open
ZLLentz opened this issue Apr 24, 2023 · 4 comments
Open

RIX paths don't match reality #183

ZLLentz opened this issue Apr 24, 2023 · 4 comments

Comments

@ZLLentz
Copy link
Member

ZLLentz commented Apr 24, 2023

Expected Behavior

  • RIX, being one beam pipe, should (probably?) have one beam path associated with it, even if there are 2 endstations
  • RIX hutch python should load a lightpath object

Current Behavior

  • Currently split into CRIX and QRIX, along K1 and K2 which doesn't quite match the reality of where these endstations are
  • RIX hutch python doesn't know which one to load, nor can it without some modifications

Possible Solution

Discuss and collaborate with RIX to figure out the correct/best way to show these

  • Combine lightpath to 1?
  • Split hutch python into 2? (and fix the start/end points for lightpath)

Context

This broke the lightpath device loading in rix hutch python because hutch is set to "rix" and we only have lightpath configs for "crix" and "qrix"

Your Environment

pcds-5.7.1

@jyotiphy
Copy link

@ZLLentz I did notice that earlier but didn't get chance to talk to @tangkong yet. I think we can combine lightpath to just RIX as the beampath is very much similar for both Endstations. We can have more discussion on this and see what fits better in this case.

@tangkong
Copy link
Contributor

The path toward combining crix and qrix seems to be simple... I think.

Currently the lightpath map looks like this, an there are devices in both the K1 and K2 lines after the branching point (mr1k2_switch)
image

To combine these lines we'd need to:

  • set the branching device to only direct beam to one line
    • this seems to have already been done, with mr1k2_switch being set to always point to K2
  • move all the devices onto one line
    • There are 25 devices on K2 and 4 devices on K1 after the branching device. We should decide if we want those devices on the K2 line ('crixs_rcc_vrc_1', 'crixs_rcc_vrc_2', 'crixs_rcc_vrc_3', 'crixs_rcc_vrc_4')
  • Rename the line endpoints to make hutch-python and lightpath match
    • could change lightpath to have the K2 line be labeled as 'RIX' (source)
    • could change RIX's hutch-python to look for QRIX and just understand that means 'RIX'

@tangkong
Copy link
Contributor

the 4 devices on the K1 line after mr1k2_switch all seem to be around z=790, are they in use still?

n [18]: [(res.metadata['name'], res.metadata['z'], res.metadata['active']) for res in K1_res if res.metadata['z'] > 74
    ...: 2.922]
Out[18]:
[('crixs_rcc_vrc_1', 790.00999, True),
 ('crixs_rcc_vrc_2', 790.00998, True),
 ('crixs_rcc_vrc_3', 790.00997, True),
 ('crixs_rcc_vrc_4', 790.00996, True)]

@ZLLentz
Copy link
Member Author

ZLLentz commented Apr 25, 2023

I think those are all on the K2 line in reality, according to the location of crix on https://confluence.slac.stanford.edu/display/L2SI/RIX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants