Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: add state_summary to LightpathState, for showing select device signal information #158

Open
tangkong opened this issue Sep 15, 2022 · 1 comment

Comments

@tangkong
Copy link
Contributor

Expected Behavior

From discussions on #157

I wonder if there is any metadata we could slide into the LightpathState dataclass to use in this space in an efficient way instead of the ad hoc "grab a few signals and make widgets".

Possible Solution

Just as an idea for a follow-up for what to do with the space, what if we extend like:

@DataClass
class LightpathState:
inserted: bool
removed: bool
transmission: float
output_branch: str
state_summary: str = ""
And then devices can provide text to lightpath to include in a label. Just a small idea, there are probably better ways to do this.

Context

#157

The commands widget was removed, and along with it the visibility of hinted signals. it might be nice to see these return, if performance issues can be solved. Implementing this should come with careful consideration of which components are being "woken up" and the ensuing performance impacts

Your Environment

pcds-5.4.2+lightpath pr's

@tangkong tangkong changed the title ENH: add state_ ENH: add state_summary to LightpathState, for showing select device signal information Sep 15, 2022
@ZLLentz
Copy link
Member

ZLLentz commented Sep 15, 2022

I think collecting the extra display data as "the device picks a string at the same time as when it figures out if its inserted" is going to be pretty efficient compared to previous "inspect the device, do some cagets, check the metadata" that needed to go on previously

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants