Move Wave8 to pcdsdevices

[teddyrendahl]

Expected Behavior

The Wave8 IOC is general enough that we should include this in pcdsdevices

[klauer]

We have https://github.com/pcdshub/pcdsdevices/blob/cfff9b2a34db9661843b84c0f863e146f8131c0e/pcdsdevices/ipm.py#L304-L339

The classes are not interchangeable and do not share the same attributes/PVs (notably, per-channel peakA and peakT are unavailable on pcdsdevices).

Unsure how these should be merged.

[ZLLentz]

Adding

hxrsnd/hxrsnd/diode.py

Line 220 in 6b7a127

class DiodeIO(SndDevice):

link for comparison purposes

[ZLLentz]

All I can say is that we need to see if these PVs would connect for the existing wave8 devices in pcdsdevices

[klauer]

This is a 🐇 🕳️ I didn't expect.

It appears that these old PVs were aliased at some point. The raw-indexed names seem temporary and undesirable:

g/pcds/epics/ioc/xcs/wave8/R0.2.0/build/iocBoot/ioc-xcs-snd-bmmon/st.cmd
46:dbLoadRecords("db/wave8alias.db", "OLD=XCS:SND:DIO:_peakA_8,NEW=XCS:SND:DIA:DD:DIODE")
47:dbLoadRecords("db/wave8alias.db", "OLD=XCS:SND:DIO:_peakA_9,NEW=XCS:SND:DIA:DCC:DIODE")
48:dbLoadRecords("db/wave8alias.db", "OLD=XCS:SND:DIO:_peakA_10,NEW=XCS:SND:DIA:DCI:DIODE")
49:dbLoadRecords("db/wave8alias.db", "OLD=XCS:SND:DIO:_peakA_11,NEW=XCS:SND:DIA:DCO:DIODE")
50:dbLoadRecords("db/wave8alias.db", "OLD=XCS:SND:DIO:_peakA_12,NEW=XCS:SND:DIA:DI:DIODE")
51:dbLoadRecords("db/wave8alias.db", "OLD=XCS:SND:DIO:_peakA_13,NEW=XCS:SND:DIA:DO:DIODE")
52:dbLoadRecords("db/wave8alias.db", "OLD=XCS:SND:DIO:_peakA_14,NEW=XCS:SND:T4:DIODE")
53:dbLoadRecords("db/wave8alias.db", "OLD=XCS:SND:DIO:_peakA_15,NEW=XCS:SND:T1:DIODE")

g/pcds/epics/ioc/xcs/wave8/R0.2.1/build/iocBoot/ioc-xcs-snd-bmmon/st.cmd
46:dbLoadRecords("db/wave8alias.db", "OLD=XCS:SND:DIO:_peakA_8,NEW=XCS:SND:DIA:DCC:DIODE")
47:dbLoadRecords("db/wave8alias.db", "OLD=XCS:SND:DIO:_peakA_9,NEW=XCS:SND:DIA:DCO:DIODE")
48:dbLoadRecords("db/wave8alias.db", "OLD=XCS:SND:DIO:_peakA_10,NEW=XCS:SND:DIA:DO:DIODE")
49:dbLoadRecords("db/wave8alias.db", "OLD=XCS:SND:DIO:_peakA_11,NEW=XCS:SND:DIA:T1D:DIODE")
50:dbLoadRecords("db/wave8alias.db", "OLD=XCS:SND:DIO:_peakA_12,NEW=XCS:SND:DIA:DD:DIODE")
51:dbLoadRecords("db/wave8alias.db", "OLD=XCS:SND:DIO:_peakA_13,NEW=XCS:SND:DIA:DCI:DIODE")
52:dbLoadRecords("db/wave8alias.db", "OLD=XCS:SND:DIO:_peakA_14,NEW=XCS:SND:DIA:DI:DIODE")
53:dbLoadRecords("db/wave8alias.db", "OLD=XCS:SND:DIO:_peakA_15,NEW=XCS:SND:DIA:T4D:DIODE")

Note that the aliases even changed between R0.2.0 and R0.2.1.

So the above says _peakA_ is aliased to (e.g., for channel 10) XCS:SND:DIA:DO:DIODE
However, looking at what that is currently:

$ caget XCS:SND:DIA:DO:DIODE.NAME
XCS:SND:DIA:DO:DIODE.NAME      XCS:SND:DIO:AMPL_10

... it's also an alias: XCS:SND:DIA:DCC:DIODE -> XCS:SND:DIO:AMPL_10
This then matches pcdsdevices.ipm.Wave8Channel.amplitude

... meaning peakA is no longer necessary. I'd guess by extension peakT is tpos

TLDR:
peakA = pcdsdevices.ipm.Wave8Channel.amplitude
peakT = pcdsdevices.ipm.Wave8Channel.tpos (** maybe; unconfirmed)