takepeds should stop if pedestal failed

[ZryletTC]

If pedestal failed for whatever reason, the script should stop. Currently, it looks like it still proceeds to post in the elog and tell users to call makepeds.

Should stop after this line:

engineering_tools/scripts/takepeds

Line 6 in a608fb6

$DAQ_RELEASE/tools/scanning/take_pedestals -p 0 -r

set -e might work (hoping that take_pedestals gives non-zero status on error)?

[silkenelson]

@ddamiani How does the underlying take_pedestals behave?

[ddamiani]

Depends on what went wrong. If the DAQ fails like a DAQ transition fails, config fails, DAQ crashes, can’t write files, etc the takepeds script should exit with a non zero status code If the detector is damaging but the daq is otherwise fine then it continues since pydaq has no way to get the damage stats (it would be a very non-trivial change to add that). Dan

…

On Jan 23, 2022, at 11:50 AM, silkenelson ***@***.***> wrote:  @ddamiani How does the underlying take_pedestals behave? — Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you were mentioned.