Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Future improvements for BLmotors #92

Open
ZryletTC opened this issue Dec 17, 2021 · 2 comments
Open

ENH: Future improvements for BLmotors #92

ZryletTC opened this issue Dec 17, 2021 · 2 comments

Comments

@ZryletTC
Copy link
Contributor

  1. Remove unnecessary argument handling Originally posted by @ZLLentz in DEV: Add Beamline motors Report Script #91 (comment)
  2. Remove exec call Originally posted by @ZLLentz in DEV: Add Beamline motors Report Script #91 (comment)
  3. Remove unnecessary tuple creation for res Originally posted by @ZLLentz in DEV: Add Beamline motors Report Script #91 (comment)
  4. Clean up file handling Originally posted by @ZLLentz in DEV: Add Beamline motors Report Script #91 (comment)
  5. Simplify device sorting logic Originally posted by @ZLLentz in DEV: Add Beamline motors Report Script #91 (comment)
  6. Fix other things left over from Mike's code...
  7. Parallelize EPICS calls Originally posted by @ZLLentz in DEV: Add Beamline motors Report Script #91 (comment)
  8. Maybe rename?
@ZryletTC ZryletTC changed the title Future improvements for BLmotors ENH: Future improvements for BLmotors Dec 17, 2021
@silkenelson
Copy link
Collaborator

Just clarifying here that this script was not originally be intended to be performant: it's a first check to make the state of the beamline motors sane. In the end, I was assuming we'd have some code in beam line python that would make a list of all beam line motors and check if they are configured as they are supposed to and maybe state the differences if not - this could become part of ATEF which might mean a different solution again. Treat the current script with the care that fits this.

@ZLLentz
Copy link
Member

ZLLentz commented Jan 3, 2022

I guess I shouldn't have reviewed it so closely then, sorry about that. I didn't have the proper context and assumed we'd be re-using and continuing to maintain the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants