Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: changing comparison data type should update dataclass value when relevant #242

Open
tangkong opened this issue Jun 6, 2024 · 0 comments

Comments

@tangkong
Copy link
Contributor

tangkong commented Jun 6, 2024

Expected Behavior

Switching a comparison data type should result in changes to the dataclass.

In some senses I am in favor of the current behavior, unless you actually change the value you shouldn't modify the dataclass. But when you change to an enum, a value is filled. It would be unintuitive in this case for ATEF to not apply this value to the dataclass

Current Behavior

If you switch a comparison's data type from e.g. float to enum and leave the combobox alone, it doesn't actually edit the dataclass in such a way to save a change. You have to manually re-select e.g. FALSE again. (Found because my test case was failing on 0.0 != 0/FALSE)

Possible Solution

Fill the values when the type changes

Steps to Reproduce (for bugs)

See current behavior

Context

#241

Your Environment

pcds-5.8.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant