Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: serialize configs with exclude_defaults=True #194

Open
tangkong opened this issue Aug 4, 2023 · 0 comments
Open

MNT: serialize configs with exclude_defaults=True #194

tangkong opened this issue Aug 4, 2023 · 0 comments

Comments

@tangkong
Copy link
Contributor

tangkong commented Aug 4, 2023

Expected Behavior

Should we serialize / save configs with exclude_defaults=True?
Pros: Conciseness
Cons: Opaqueness

Current Behavior

Currently we include all the defaults when we save a config

In other places we intend to exclude defaults, but never actually hit upon this code path

Possible Solution

  • exclude defaults in

    return serialize(
    type(tree.config_file),
    tree.config_file,
    )

  • re-generate the test configs so round-trip tests don't fail

Context

musing as I poked around

Your Environment

pcds-5.7.3, atef v1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant