We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exclude_defaults=True
Should we serialize / save configs with exclude_defaults=True? Pros: Conciseness Cons: Opaqueness
Currently we include all the defaults when we save a config
In other places we intend to exclude defaults, but never actually hit upon this code path
exclude defaults in
atef/atef/widgets/config/window.py
Lines 310 to 313 in a23ac31
re-generate the test configs so round-trip tests don't fail
musing as I poked around
pcds-5.7.3, atef v1.0.0
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Expected Behavior
Should we serialize / save configs with
exclude_defaults=True
?Pros: Conciseness
Cons: Opaqueness
Current Behavior
Currently we include all the defaults when we save a config
In other places we intend to exclude defaults, but never actually hit upon this code path
Possible Solution
exclude defaults in
atef/atef/widgets/config/window.py
Lines 310 to 313 in a23ac31
re-generate the test configs so round-trip tests don't fail
Context
musing as I poked around
Your Environment
pcds-5.7.3, atef v1.0.0
The text was updated successfully, but these errors were encountered: