Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT: range comparison should not allow invalid ranges #192

Open
tangkong opened this issue Jul 10, 2023 · 0 comments
Open

MNT: range comparison should not allow invalid ranges #192

tangkong opened this issue Jul 10, 2023 · 0 comments

Comments

@tangkong
Copy link
Contributor

Expected Behavior

We should probably throw an error or let the user know if the range specified by the user is invalid (e.g. 1 < x < 0)

Current Behavior

The user will only know this is a problem when the comparison fails, and it's not a very loud complaint at that

Possible Solution

raise a ValueError

Context

A user ran into this accidentally

Your Environment

atef 1.0.0, pcds-5.7.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tangkong