Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the timeout in FindNodesWithoutDeserializing configurable #251

Open
TristanSpeakEasy opened this issue Feb 13, 2024 · 1 comment
Open

Make the timeout in FindNodesWithoutDeserializing configurable #251

TristanSpeakEasy opened this issue Feb 13, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@TristanSpeakEasy
Copy link
Contributor

This timeout for reference https://github.com/pb33f/libopenapi/blob/main/utils/utils.go#L118

Will submit a PR to bump it to 500ms for now if that is okay
@TristanSpeakEasy TristanSpeakEasy mentioned this issue Feb 13, 2024
Merged
@daveshanley daveshanley added the enhancement New feature or request label Feb 14, 2024
@daveshanley
Copy link
Member

daveshanley commented Feb 14, 2024 •
edited
Loading

This timeout exists to prevent run-away lookups. This does not happen with any of the built in vacuum rules anymore, but it used to with the OWASP rules, which means any built-in functions have the potential to run-away into an endless loop.

The timeout should be configurable.

@daveshanley daveshanley mentioned this issue May 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daveshanley @TristanSpeakEasy