Order checkout complete fail il phone number is incorrect

[rv-garnier]

Hello,

If I have a malformed phone number for the delivery or billing address, and I don't have validation via the Symfony form, I get an error at the complete checkout step, when i payment is captured.

request.CRITICAL: Uncaught PHP Exception libphonenumber\NumberParseException: "The string supplied did not seem to be a phone number." at PhoneNumberUtil.php line 1673 {"exception":"[object] (libphonenumber\NumberParseException(code: 1): The string supplied did not seem to be a phone number. at /apps/sylius/vendor/giggsey/libphonenumber-for-php/src/PhoneNumberUtil.php:1673)"}

In my example, phone number was a simple hyphen.

Solution must be to catch NumberParseException in PayPlug\SyliusPayPlugPlugin\Creator\PayPlugPaymentDataCreator, formatNumber function :

public function formatNumber(string $phoneNumber, ?string $isoCode): array
{
    try {
        $phoneNumberUtil = PhoneNumberUtil::getInstance();
        $parsed = $phoneNumberUtil->parse($phoneNumber, $isoCode);

        if (!$phoneNumberUtil->isValidNumber($parsed)) {
            return [
                'phone' => null,
                'is_mobile' => null,
            ];
        }

        $formatted = $phoneNumberUtil->format($parsed, PhoneNumberFormat::E164);

        return [
            'phone' => $formatted,
            'is_mobile' => PhoneNumberType::MOBILE === $phoneNumberUtil->getNumberType($parsed),
        ];
    }
    catch (NumberParseException $e) {
        return [
            'phone' => null,
            'is_mobile' => null,
        ];
    }
}

[dmurillo-payplug]

Hello,

Thank you for bringing this issue to our attention.

We will review this issue and investigate the proposed solution to ensure it resolves the problem effectively without introducing any new issues. Our team will need some time to thoroughly test and verify the fix.

We will update you as soon as we have more information or a resolution.

[dmurillo-payplug]

Hello, this issue has been solved in the version 1.9.3.

Thanks for taking the time to report it.