Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a global trigger argument for wait timeout. #81

Open
mengchen2 opened this issue Oct 19, 2018 · 1 comment
Open

Add a global trigger argument for wait timeout. #81

mengchen2 opened this issue Oct 19, 2018 · 1 comment

Comments

@mengchen2
Copy link

locatorObject[locatorId + 'Wait'] = function (timeout, msg) {
return drivex.waitForElementPromise(locator(), timeout || 5000, msg || 'Wait failed for locator [' +
locatorId + ']');
};
locatorObject[locatorId + 'WaitVisible'] = function (timeout, msg) {
return drivex.waitForElementVisiblePromise(locator(), timeout || 5000, msg || 'WaitVisible failed for locator [' + locatorId + ']');

If we don't provide a timeout value to the wait() method, the default timeout is only 5s, which sometime not long enough.

To have all that 5s default timeout to be config globally by a plugin arg will be great

@mengchen2
Copy link
Author

PR #82 raised for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant