Update Refund Function to Skip Treasury Transfer for Zero Fee

[Shallysunny]

User Story

As a developer, I want to ensure that the refund fee is not transferred to the treasury if the fee value is 0, so that unnecessary transactions are avoided.

Acceptance Criteria

1. GIVEN an order with a refund fee of 0,
   WHEN the refund function is called,
   THEN the system should not transfer the refund fee to the treasury.

2. GIVEN an order with a refund fee greater than 0,
   WHEN the refund function is called,
   THEN the system should transfer the refund fee to the treasury as usual.

Product & Design Links:

Tech Details:

• Update the refund function to include a check that ensures the refund fee is not transferred to the treasury if the fee value is 0.
• Ensure proper error handling and validation for the refund functionality.

Open Questions:

Notes/Assumptions:

Code Changes

Update the refund function as follows:

function refund(uint256 _fee, bytes32 _orderId) external onlyAggregator returns (bool) {
    ...

    // transfer refund fee to the treasury if the fee is not 0
    if (_fee != 0) {
        IERC20(order[_orderId].token).transfer(treasuryAddress, _fee);
    }

   ...
}