Completion of error handling

[elfring]

Would you like to add more error handling for return values from functions like the following?

• fseek ⇒ Parse
• malloc ⇒ ParseCopyParserState

[pawelsalawa]

Files that you're referring to are imported from official SQLite sources (though from quite an old version of SQLite). I'm not familiar enough with their details of implementation to comfortably modify them. It would take significant effort to analyze them first. I don't think the benefit is worth the effort.

[elfring]

I don't think the benefit is worth the effort.

How much does this software depend on the component “LEMON LALR(1) parser generator”?

---

💭 I suggest to avoid ignorance of return values a bit more.
Would you like to detect every error situation as early as possible?

[pawelsalawa]

A lot. This is the parser used to understand SQL syntax of SQLite (for code assistant, code formatter, editing DDL objects, and a lot more). Why do you ask?

[elfring]

💭 I became interested in further collateral software evolution.

[elfring]

💭 I hope that more code reviewers and developers will become interested in corresponding software improvements.

[pawelsalawa]

I see. Just keep in mind, that SQLiteStudio uses relatively old version of Lemon parser and I had no need to update it so far. Updating is difficult, because I already introduced significant SQLiteStudio-specific changes to the Lemon included with SQLiteStudio.

[elfring]

Updating is difficult, because I already introduced significant SQLiteStudio-specific changes to the Lemon included with SQLiteStudio.

• 💭 Can any of these parser adjustments become helpful also for a more recent software version?
• 🔮 Would SQLite contributors become accordingly interested in further improvements?

[elfring]

🤔 How do you think about to improve static source code analysis also for this software?

[pawelsalawa]

I use embedded clang static analysis (as QtCreator plugin) since few months and I'm improving it on-the-fly whenever I touch files.

[elfring]

💭 Would you become interested in aspect-oriented software development?

[pawelsalawa]

Why all these questions?

[elfring]

💭 Some advanced development tools can help more to fix remaining open issues.

🤔 Can any more developers become aware that error detection belongs to known cross-cutting concerns?

[elfring]

👀 Some analysis tools can point remaining open issues out.

💭 I imagine that pointcuts and advices can be developed accordingly.