Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/add attachment #95

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Refactor/add attachment #95

merged 2 commits into from
Aug 19, 2024

Conversation

consolethinks
Copy link
Collaborator

refactors add attachment:

  • improvements
  • fix a bug

sbliven
sbliven approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@sbliven sbliven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward PR lifting error logging up to the main function.

@sbliven sbliven mentioned this pull request Aug 19, 2024
Closed
@consolethinks consolethinks merged commit e5cc2bc into main Aug 19, 2024
3 checks passed
@consolethinks consolethinks deleted the refactor/add_attachment branch August 19, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbliven sbliven sbliven approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@consolethinks @sbliven