Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check rsync version #43

Merged
merged 5 commits into from
Apr 25, 2024
Merged

Check rsync version #43

merged 5 commits into from
Apr 25, 2024

Conversation

kavir1698
Copy link
Collaborator

Will fix #42

@kavir1698 kavir1698 requested a review from a team April 22, 2024 11:25
minottic
minottic reviewed Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@minottic minottic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

going forward we could see if there is a go rsync wrapper.

Would it be easy to add tests on the functions that use rsync to see if they still fail?

datasetIngestor/syncDataToFileserver_unix.go Show resolved Hide resolved
datasetIngestor/syncDataToFileserver_unix.go Outdated Show resolved Hide resolved
@kavir1698
Copy link
Collaborator Author

going forward we could see if there is a go rsync wrapper.

Would it be easy to add tests on the functions that use rsync to see if they still fail?

After a little searching, I found a few rsync wrapper but they don't seem to be well maintained.

I tested the ingest manually and it worked. Testing SyncDataToFileserver would be a bit tricky with a lot of mocking.

@minottic minottic self-requested a review April 22, 2024 14:25
@minottic minottic self-requested a review April 23, 2024 13:58
@minottic minottic self-requested a review April 23, 2024 14:27
sbliven
sbliven approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@sbliven sbliven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for me in -testenv from pmod7 (springdale 7.9) and ra-l-005 (rhel 8).

datasetIngestor/syncDataToFileserver_unix.go Show resolved Hide resolved
@kavir1698
Copy link
Collaborator Author

Since it wasn't working on RHEL9 before, and now the problem is just not printing the output, and since Spencer needs to have the version here up to 2.2.0, I think it is safe that we merge this now and fix the printing problem in a later PR

@sbliven
Copy link
Member

sbliven commented Apr 25, 2024

Seems reasonable. 🚀

This was referenced Apr 25, 2024
Open
Open
@sbliven sbliven merged commit 59cde32 into main Apr 25, 2024
3 checks passed
@sbliven sbliven deleted the check_rsync_version branch April 25, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbliven sbliven sbliven approved these changes

@minottic minottic minottic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check rsync version
3 participants
@kavir1698 @sbliven @minottic