Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing browser compatibility declaration on GitHub project homepage #46

Open
dannya opened this issue Sep 20, 2013 · 5 comments
Open

Comments

@dannya
Copy link

dannya commented Sep 20, 2013

As you checkout the project README at https://github.com/paulirish/matchMedia.js clearly the most important thing you need to know about a polyfill is missing... browser compatibility!

The README should show (preferably near the top) the minimum browsers (IE, etc) that this will work with.

@markusfalk
Copy link

Took me a while too to find out why IE8 won't do what I wanted it to do. Maybe note that even if used through respondJS IE8 won't work

@smohadjer
Copy link

Same here! :(

The polyfill from David Knight however works in ie8. That's what I ended up using. You can get it from: https://github.com/weblinc/media-match

@benschwarz
Copy link
Collaborator

@smohadjer David's code ended up in matchMedia.js. You're recommending a library that hasn't been updated in 2 years.

matchMedia somewhat confuses the issue by calling itself a polyfill —

While it is a polyfill for window.matchMedia, that is only for browsers that actually support media queries. (Thusly, no IE8 support).

Any library that "supports media queries" in IE8 is doing something hacky, and should probably best be avoided because there are more than likely going to be some bad performance results.

@smohadjer
Copy link

I don't care if it's ten years old, as long as it does the job! ;)

@tejaswagh1805
Copy link

I can't understand...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants