You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
When casting to floats, small changes may occur such as 0.1 to 0.100000001490116119384765625.
Could this just be floats being floats? It seems like it may be more of a "how different languages format numbers by default" issue than anything else.
Yeah, it is just floats being floats. But I just wasn't sure if n5 is used in cases where floating point precision might be an issue. You should always be able to write and read float64 exactly, but should we throw a warning or error if you try to write ints to a float dataset which works, but is imprecise
That's a good call. Given numpy arrays have strict types which can easily be cast between anyway, I'd throw an error if someone tried to write an int array to a float dataset - make the caller do my_int_array.astype(float) if that's what they want (explicit is better than implicit).
Thats what I was thinking. Its not a huge priority for now, so I'll leave it with expected fail tests. I think this problem should resolve itself when we build in numpy support to the rust side
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Improve testing of float datatypes
Problems with datasets of type float
The text was updated successfully, but these errors were encountered: