Skip to content
This repository has been archived by the owner on Jul 11, 2018. It is now read-only.

Duplicate listing when more than one language extension providing symbols #141

Open
ant-g opened this issue Jun 5, 2018 · 3 comments
Open
Labels

Comments

@ant-g
Copy link

ant-g commented Jun 5, 2018

I have two PHP extensions active Intellisense and Intelephense, so there are two sets of symbol data being created which do not get filtered when showing the code outline:
image

Would be good if duplicates could be spotted and excluded from the tree?

@patrys
Copy link
Owner

patrys commented Jun 5, 2018

I'm not sure what to do about this. Would need to check if the symbols have identical ranges.

@patrys patrys added the bug label Jun 5, 2018
@ant-g
Copy link
Author

ant-g commented Jun 5, 2018

I'm not familiar with typescript or vscode api, but if range is what is used to point to the correct file and line when selecting the node, then yes that would seem sensible to identify duplicates.

If you get the nodes from vs code in order, then it may just be a case of compare with previous or it might be a post-process activity once the initial tree is drawn and ordered, to loop through doing the compare with previous and removing/hiding if necessary?

Is there anything in the API that identifies the 'provider' or 'owner' of the symbol entry? If so then only pull in data from a single provider?

@fmerici
Copy link

fmerici commented Jun 7, 2018

I see same issue for Java

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants