Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds line height parameter to text component #925

Merged
merged 9 commits into from
Nov 6, 2024
Merged

Adds line height parameter to text component #925

merged 9 commits into from
Nov 6, 2024

Commits on Nov 6, 2024

  1. Adds line height parameter to text component

    @cristianboicu01 @Gowsky
    cristianboicu01 authored and Gowsky committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    805d332 View commit details
    Browse the repository at this point in the history

  2. Adds documentation for line height paramter

    @cristianboicu01 @Gowsky
    cristianboicu01 authored and Gowsky committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    1cbd6c5 View commit details
    Browse the repository at this point in the history

  3. Adds line height xml attribute

    @cristianboicu01 @Gowsky
    cristianboicu01 authored and Gowsky committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    db6d034 View commit details
    Browse the repository at this point in the history

  4. Reads line height attribute and applies value to text component.

    @cristianboicu01 @Gowsky
    cristianboicu01 authored and Gowsky committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    e5de997 View commit details
    Browse the repository at this point in the history

  5. refactoring

    @cristianboicu01 @Gowsky
    cristianboicu01 authored and Gowsky committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    ce441c8 View commit details
    Browse the repository at this point in the history

  6. Updates getRawDimension to use getRawDimensionOrNull

    @cristianboicu01 @Gowsky
    cristianboicu01 authored and Gowsky committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    3bdef6e View commit details
    Browse the repository at this point in the history

  7. Refactors computeSpacingAddition and adds missing paranthesis

    @cristianboicu01 @Gowsky
    cristianboicu01 authored and Gowsky committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    59a0a59 View commit details
    Browse the repository at this point in the history

  8. Reformat code in TypedArray.kt and TextComponentStyle.kt

    @Gowsky
    Gowsky committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    71f2bcb View commit details
    Browse the repository at this point in the history

  9. Make lineHeightSp define the actual line height, and not an additio… 

    …nal spacing

Co-authored-by: Patrick Michalik <[email protected]>
    @Gowsky @patrickmichalik
    Gowsky and patrickmichalik committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    d0fa1c4 View commit details
    Browse the repository at this point in the history