-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds line height parameter to text component #925
Adds line height parameter to text component #925
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, @cristianboicu01. Thank you for your contribution. The PR looks good overall, but we'd like to request 2 changes:
- Add a missing documentation for
lineHeight
andlineHeightSp
parameters. - Add an XML attribute for the line height.
Hello @Gowsky. Thank you for the comments. Hope I got it right with the xml attributes. Let me know if I missed anything. |
Adding an XML attribute declaration is not enough. You have to read it and apply it to |
vico/views/src/main/java/com/patrykandpatrick/vico/views/common/theme/TypedArray.kt
Outdated
Show resolved
Hide resolved
vico/core/src/main/java/com/patrykandpatrick/vico/core/common/component/TextComponent.kt
Outdated
Show resolved
Hide resolved
vico/core/src/main/java/com/patrykandpatrick/vico/core/common/component/TextComponent.kt
Outdated
Show resolved
Hide resolved
e1ed616
to
b505264
Compare
be69f6c
to
735920a
Compare
…nal spacing Co-authored-by: Patrick Michalik <[email protected]>
808077b
to
d0fa1c4
Compare
Thank you for your contribution @cristianboicu01! |
Provides a way to customise the line height for a text component.