Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds line height parameter to text component #925

Merged

Conversation

cristianboicu01
Copy link
Contributor

Provides a way to customise the line height for a text component.

Copy link
Member

@Gowsky Gowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @cristianboicu01. Thank you for your contribution. The PR looks good overall, but we'd like to request 2 changes:

  • Add a missing documentation for lineHeight and lineHeightSp parameters.
  • Add an XML attribute for the line height.

@cristianboicu01
Copy link
Contributor Author

Hello @Gowsky. Thank you for the comments.

Hope I got it right with the xml attributes. Let me know if I missed anything.

@Gowsky
Copy link
Member

Gowsky commented Oct 21, 2024

Let me know if I missed anything.

Adding an XML attribute declaration is not enough. You have to read it and apply it to TextComponent, as it won't work just like that.

@Gowsky Gowsky merged commit d0fa1c4 into patrykandpatrick:master Nov 6, 2024
3 checks passed
@Gowsky
Copy link
Member

Gowsky commented Nov 6, 2024

Thank you for your contribution @cristianboicu01!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants