Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLP "depth" parameter doc #780

Open
tyagi-ankit opened this issue Jul 10, 2024 · 2 comments
Open

MLP "depth" parameter doc #780

tyagi-ankit opened this issue Jul 10, 2024 · 2 comments
Labels
documentation Improvements or additions to documentation

Comments

@tyagi-ankit
Copy link

It says:

depth: The number of hidden layers, including the output layer. For example, depth=2 results in an network with layers: [Linear(in_size, width_size), Linear(width_size, width_size), Linear(width_size, out_size)].

Shouldn't it be "excluding"? From the example it looks like that.

@patrick-kidger
Copy link
Owner

Hmm, based on my reading that looks correct. In the example we have (a) the input layer, and then (b) two more layers. Corresponding to depth=2.

There's never been a great job at standardising terminology in the field here, however...

@patrick-kidger patrick-kidger added the documentation Improvements or additions to documentation label Jul 13, 2024
@tyagi-ankit
Copy link
Author

Thanks for the answer Patrick. It's confusing to me. I thought input and output layers are never counted as hidden layers. To me, input layer has no parameters. So, when it says "The number of hidden layers, including the output layer", I read (a) 2 hidden layers, and then (b) one output layer.

But thanks for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants