PatchWork AutoFix #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 25, 2024 10:23
…e0jhosi/src/main/java/io/shiftleft/controller/AdminController.java
…e0jhosi/src/main/java/io/shiftleft/controller/CustomerController.java
…e0jhosi/src/main/resources/config/application-aws.properties
…e0jhosi/src/main/java/io/shiftleft/data/DataBuilder.java
…e0jhosi/src/main/java/io/shiftleft/controller/SearchController.java
…e0jhosi/src/main/java/io/shiftleft/controller/AppErrorController.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request from patched fixes 6 issues.
Fix path traversal vulnerability in saveSettings method
Sanitized user input to prevent path traversal vulnerability by using FilenameUtils.getName to retrieve the file name from the path.Fix object deserialization vulnerability and set 'HttpOnly' and 'secure' flags for cookies
Fixed object deserialization vulnerability by ensuring deserialized objects are safe. Set 'HttpOnly' and 'secure' flags for cookies in appropriate places.Fix vulnerability by specifying HTTP method in @RequestMapping annotation
Added 'method = RequestMethod.GET' to the @RequestMapping annotation for the 'errorHtml' method to specify the HTTP method explicitly.Fix potential code injection vulnerability
Added validation to sanitize user input before parsing it as an expression to prevent potential code injection vulnerability.Remove debug code from DataBuilder class
Removed the System.out.println statements used for debugging purposes.Fix hardcoding of AWS Access Key ID
Removed hardcoded AWS Access Key ID value and suggested to read it from an environment variable or keep it in a separate, private file.