You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the plugin jar is published as net.rdrei.android.buildtimetracker:gradle-plugin; the artifact name is too general to be useful. Perhaps it can be called build-time-tracker-plugin, same as the repo name.
The text was updated successfully, but these errors were encountered:
I remember taking this naming convention from some other plugin. I'm a bit hesitant as those changes are quite disruptive. Is this breaking anything in particular for you?
Matter of fact, it is. We use common build.gradle files that are included in various other builds. For backward compatibility, and since buildscript section is not included, but plugins are, we try to apply new plugins conditionally after checking the buildscript path. If a plugin is found on the path, we will apply it. The overly generic name of the build time tracker plugin is a problem because many other plugins also have the words gradle-plugin in their names, like the spring-boot-gradle-plugin for example, so it makes it impossible to determine whether the plugin is present on the path or not. Following is the snippet of code that I'm referring to:
For now, I'm using file(it).absolutePath.contains("buildtimetracker") to get around this problem, but I think pattern matching absolute path is taking it too far.
If the name changes with a new version, people updating their build files to pick up the new version should be able to update a few more characters to pick up the new name. It's not the end of the world.
Currently the plugin jar is published as
net.rdrei.android.buildtimetracker:gradle-plugin
; the artifact name is too general to be useful. Perhaps it can be calledbuild-time-tracker-plugin
, same as the repo name.The text was updated successfully, but these errors were encountered: