feat: add value for supplying an existing secret containing the JWT server keypair #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @Kuruyia sorry for the delay. Yeah we could think about a message to be added when jwtCreateKeysForced and jwtExistingSecret are used at the same time. This is what you are describing if I understood it correctly, right? |
|
Hi, no problem ! Yep I was thinking about that. |
|
We'll add the message in a separate release but it is a good idea indeed. This PR has been merged in 0.7.1 we accidentally squashed the PR, sorry about that. In any case we really appreciate your contributions!! Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pretty much #60 for the JWT keypair.
This time, the value added is
jwtExistingSecretto allow providing an existing secret containing thejwt.keyandjwt.pemkeys.Also, it might be good to think about how the
jwtCreateKeysForced,jwtServerPublic/jwtServerPrivateandjwtExistingSecretvalues interact with each other, as they are (imho) mutually exclusive and should not be used together. Maybe display a message to the user and abort the install of the chart?Same remark for
gpgServerKeyPublic/gpgServerKeyPrivatevs.gpgExistingSecret.