Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use list instead of string for extra volumes and extra volume mounts #61

Merged
merged 2 commits into from
Apr 25, 2024
Merged

feat: use list instead of string for extra volumes and extra volume mounts #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3214755
feat: use list instead of string for extra volumes and extra volume m…
Kuruyia Nov 21, 2023
0dfa62b
chore: merge main and fix conflicts
Kuruyia Nov 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,8 @@ chart and deletes the release.
| autoscaling.minReplicas | int | `1` | Configure autoscaling minimum replicas |
| autoscaling.targetCPUUtilizationPercentage | int | `80` | Configure autoscaling target CPU uptilization percentage |
| cronJobEmail | object | `{"enabled":true,"extraPodLabels":{},"schedule":"* * * * *"}` | Enable email cron |
| extraVolumeMounts | string | `""` | Add additional volume mounts, e.g. for overwriting config files |
| extraVolumes | string | `""` | Add additional volumes, e.g. for overwriting config files |
| extraVolumeMounts | list | `[]` | Add additional volume mounts, e.g. for overwriting config files |
| extraVolumes | list | `[]` | Add additional volumes, e.g. for overwriting config files |
| fullnameOverride | string | `""` | Value to override the whole fullName |
| global.imagePullSecrets | list | `[]` | |
| global.imageRegistry | string | `""` | |
Expand Down
4 changes: 2 additions & 2 deletions templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ spec:
readOnly: true
{{- end }}
{{- with .Values.extraVolumeMounts }}
{{- tpl . $ | nindent 12 }}
{{- toYaml . | nindent 12 }}
{{- end }}
resources:
{{- toYaml .Values.app.resources | nindent 12 }}
Expand Down Expand Up @@ -215,5 +215,5 @@ spec:
secretName: {{ $Name }}-sec-redis-proxy
{{- end -}}
{{- with .Values.extraVolumes }}
{{- tpl . $ | nindent 8 }}
{{- toYaml . | nindent 8 }}
{{- end }}
4 changes: 2 additions & 2 deletions tests/values-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ tolerations: []
affinity: {}

# -- Add additional volumes, e.g. for overwriting config files
extraVolumes: ""
extraVolumes: []

# -- Add additional volume mounts, e.g. for overwriting config files
extraVolumeMounts: ""
extraVolumeMounts: []
4 changes: 2 additions & 2 deletions values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,7 @@ tolerations: []
affinity: {}

# -- Add additional volumes, e.g. for overwriting config files
extraVolumes: ""
extraVolumes: []

# -- Add additional volume mounts, e.g. for overwriting config files
extraVolumeMounts: ""
extraVolumeMounts: []