New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is the vendor data needed? #1

Open

mensfeld opened this issue Nov 25, 2020 · 0 comments

mensfeld commented Nov 25, 2020

While reviewing the changes for this lib, I noticed, that the vendor directory is being included.

Is this needed? Usually, it's added by mistake and causes:
a) confusion
b) problems when tracking changes

ref: https://my.diffend.io/gems/passbase/1.1.0/1.2.0

If the presence of vendor data is valid I would love the reasoning. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment