Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SetEnabled does not disable button #24

Open
hellojoe88 opened this issue Nov 21, 2016 · 11 comments
Open

SetEnabled does not disable button #24

hellojoe88 opened this issue Nov 21, 2016 · 11 comments

Comments

@hellojoe88
Copy link

I have a Textbox that should be filled before the upload should be enabled:

2016-11-21 10_00_29-einstellungen

When I call setEnabled(false) on the UploadField it is not disabled. The CSSLayout is set to disabled but not the button itself. (Which I would assume would happen if the button is inside the CSSLayout).

@mstahv
Copy link
Collaborator

mstahv commented Nov 21, 2016

Hi, which version of Vaadin & EasyUploads are you using?

@mstahv
Copy link
Collaborator

mstahv commented Nov 21, 2016

For me disabling works just fine, but cannot re-enable the field.

mstahv added a commit that referenced this issue Nov 21, 2016
@hellojoe88
Copy link
Author

hellojoe88 commented Nov 21, 2016

Hi, which version of Vaadin & EasyUploads are you using?

Oh yeah sorry. Vaadin version 7.7.1 and easyuploads version 7.4.10

For me disabling works just fine, but cannot re-enable the field.

Same here: The first state it is set to does not change anymore (enabled or disabled)

@mstahv
Copy link
Collaborator

mstahv commented Nov 21, 2016

Looks like this is some sort of core Vaadin issue. Rather critical IMO. The test I created now contains an example how to reproduce it with plain Vaadin as well. For some reason the disabled/enabled state from parent does not propagate properly.

@hellojoe88
Copy link
Author

It seems to me that it is only the case of CssLayout. In the same form I have a vertical layout where his works just fine.

@hellojoe88
Copy link
Author

hellojoe88 commented Nov 21, 2016

It seems to me that it is only the case of CssLayout. In the same form I have a vertical layout where his works just fine.

Although there I am using just Textboxes.

@mstahv
Copy link
Collaborator

mstahv commented Nov 21, 2016

For me it is reproducable with both CssLayout and VerticalLayout.

@hellojoe88
Copy link
Author

For me it is reproducable with both CssLayout and VerticalLayout.

With the UploadField element or with plain TextBoxes?

@mstahv
Copy link
Collaborator

mstahv commented Nov 21, 2016

I can only reproduce this with UploadField or Upload, not with TextField. Probably the issue is in the client side implementation of Upload component. Luckily there is an additional server side check, so that this don't cause security issue, not just a nasty bug.

@mstahv
Copy link
Collaborator

mstahv commented Nov 23, 2016

I created a core FM bug report for this:

https://dev.vaadin.com/ticket/20476#ticket

@hellojoe88
Copy link
Author

I created a core FM bug report for this

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants