Window function

[yliuuuu]

Relevant Issues

• [Related To] Issue Implement LAG and LEAD functions #603

Description

• The experimental implementation for Lag and Lead function.
• See :
  • PR Window func parsing #823 Window function Parsing
  • PR Window operator #824 Window Operator
  • PR Window refactor #830 Window Function Modeling

Key points:

• Ability to parsing window function
• AST, Logical, Logically resolved, Physical representation of window function.
• Sort based framework.
• Lag and Lead implementation and test cases.
• Optimization pass to merge window functions that operate on the same window partition to a single window operator (at the level of physical pass).
• Experimental Tag.

Points to address:

• experimental annotation Window refactor #830 (comment)
• the use of VarDecl vs SetVariableFunc Window refactor #830 (comment)

Other Information

• Updated Unreleased Section in CHANGELOG: [YES/NO]
  • Yes.
• Any backward-incompatible changes? [YES/NO]
  • No
• Any new external dependencies? [YES/NO]
• No

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[codecov-commenter]

Codecov Report

Base: 80.45% // Head: 80.64% // Increases project coverage by +0.19% 🎉

Coverage data is based on head (2e74645) compared to base (664b025).
Patch coverage: 90.97% of modified lines in pull request are covered.

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #884      +/-   ##
============================================
+ Coverage     80.45%   80.64%   +0.19%     
- Complexity     2124     2161      +37     
============================================
  Files           252      259       +7     
  Lines         16213    16493     +280     
  Branches       2893     2922      +29     
============================================
+ Hits          13044    13301     +257     
- Misses         2307     2318      +11     
- Partials        862      874      +12     

Flag	Coverage Δ
CLI	22.41% <ø> (ø)
EXAMPLES	78.63% <ø> (ø)
EXTENSIONS	69.23% <ø> (ø)
LANG	83.06% <90.97%> (+0.16%)	⬆️
PARTIQL_PTS	∅ <ø> (∅)
PARTIQL_TEST_SCRIPT	80.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...iql/lang/eval/physical/PhysicalPlanCompilerImpl.kt	83.35% <ø> (ø)
...l/physical/operators/SortOperatorFactoryDefault.kt	83.33% <ø> (ø)
...c/org/partiql/lang/prettyprint/ASTPrettyPrinter.kt	80.62% <0.00%> (-0.15%)	⬇️
...lang/eval/physical/window/BuiltInWindowFunction.kt	60.00% <60.00%> (ø)
...g/src/org/partiql/lang/eval/physical/window/Lag.kt	70.00% <70.00%> (ø)
.../src/org/partiql/lang/eval/physical/window/Lead.kt	75.00% <75.00%> (ø)
lang/src/org/partiql/lang/errors/ErrorCode.kt	87.16% <80.00%> (-0.05%)	⬇️
...ang/eval/physical/PhysicalBexprToThunkConverter.kt	86.82% <80.00%> (-0.90%)	⬇️
...sforms/LogicalToLogicalResolvedVisitorTransform.kt	93.61% <85.71%> (-0.51%)	⬇️
...planner/transforms/AstToLogicalVisitorTransform.kt	86.30% <91.80%> (+2.04%)	⬆️
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[am357]

Thank you for the great effort in putting together this experimental feature; I know the bits and pieces of this have already been reviewed by others in other PRs. Considering that I had a cursory review and left some comments related to style, duplicate code reduction, etc. Overall LGTM.

[johnedquinn]

Overall looks really good. Great job pulling in the changes from the last PRs. Great job.