Update Sidebar.tsx

[parthikjadav]

fixed this issue asyncapi#1109

Description

Changes proposed in this pull request:

The anchor link for a message in the sidebar does not work as expected when message.name() and message.id() differ.

Expected result
Clicking on a message in the sidebar should set the correct hash in the URL and scroll the message into view.

Actual result
The anchor link only works if message.name() and message.id() are identical.
If message.name() is not provided, the hash becomes #message-undefined.

before

after

Summary by Sourcery

Bug Fixes:

• Fix the issue where the anchor link in the sidebar did not work correctly when message.name() and message.id() differed by changing the href attribute to use message.id().

[sourcery-ai]

Reviewer's Guide by Sourcery

The PR fixes an issue with sidebar message links by updating the anchor href attribute to use message.id() instead of message.name(). This change ensures that the anchor links work correctly regardless of whether message.name() is defined or different from message.id().

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Updated anchor link generation in sidebar message list	Changed href attribute to use message.id() instead of message.name() Added explanatory comment about the fix for undefined name issue	library/src/containers/Sidebar/Sidebar.tsx

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @parthikjadav - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

suggestion (bug_risk): Consider using message.id() instead of message.name() in the key prop for consistency

Since message.name() was replaced with message.id() in the href to fix undefined values, the same change should be applied to the key prop to maintain consistency and prevent potential React reconciliation issues.

       </a>
       <ul className="text-sm mt-2">
         {messages.map((message, index) => (
          <li key={`menu-message-list-${message.id() ?? index}`}>