Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cooling tables inconsistent with convention #98

Closed
BenWibking opened this issue Feb 13, 2024 · 1 comment
Closed

cooling tables inconsistent with convention #98

BenWibking opened this issue Feb 13, 2024 · 1 comment

Comments

@BenWibking
Copy link
Contributor

BenWibking commented Feb 13, 2024

The cooling tables in the repository are inconsistent with the convention expected by AthenaPK (#97).

https://github.com/parthenon-hpc-lab/athenapk/tree/main/inputs/cooling_tables

For temperatures about $10^{5.5}$ K where CIE is valid, this causes a 10-20% discrepancy in expected vs. actual cooling rate.

@BenWibking
Copy link
Contributor Author

Fixed by #97.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant