Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Origin of Schure cooling table #9

Closed
pgrete opened this issue Nov 14, 2022 · 3 comments
Closed

Origin of Schure cooling table #9

pgrete opened this issue Nov 14, 2022 · 3 comments
Labels
question Further information is requested

Comments

@pgrete
Copy link
Contributor

pgrete commented Nov 14, 2022

Where does the data in the Schure cooling table actually come from, @forrestglines ?
The comment say

# Cooling table for solar metallicity, 1/2 solar metallicity
#   (from Chris Loken, computed with Sarazin & White's analytic expression)
#  temperature if log(K), cooling rate/ne^3 (erg cm^3/s)
# This is the new cooling table based on http://arxiv.org/pdf/0909.5204v2

but when I look at the pdf
a) there are slight discrepancies in the numbers for solar metallicity (table 2)
b) there's no table for the half-solar metallicity column

To be clear, I'm not concerned that those numbers are "wrong" (or that the slight deviation have a significant impact), I just want to understand where they come from.

@pgrete pgrete added the question Further information is requested label Nov 14, 2022
@forrestglines
Copy link
Contributor

That cooling table was given to me when I started at MSU along with other initial parameters for Enzo. It's also not included inside Enzo so I assume it's just one of those files that tend to be passed around developers without much thought. If we can't figure out where it comes from, we should remove it from the repo.

Brian might know where that file comes from.

@pgrete
Copy link
Contributor Author

pgrete commented Nov 17, 2022

Brian might know where that file comes from.

In this case, ping @bwoshea

@BenWibking
Copy link
Contributor

This issue is fixed by #97.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants