Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add low-mach correction to HLLC solver #18

Open
BenWibking opened this issue Feb 1, 2023 · 3 comments · May be fixed by #80
Open

add low-mach correction to HLLC solver #18

BenWibking opened this issue Feb 1, 2023 · 3 comments · May be fixed by #80

Comments

@BenWibking
Copy link
Contributor

BenWibking commented Feb 1, 2023

This will be useful for many galaxy cluster applications.

There is

HLLC-LM is not stable for very low-amplitude linear waves, but it works well otherwise. I'm not sure which is best. Both have ad-hoc modifications to recover the $\mathcal{M} \rightarrow 0$ limit, and both suppress carbuncles.

@pgrete
Copy link
Contributor

pgrete commented Feb 1, 2023

If you quickly want to try it, I have a hacked version of the latter in a branch for testing (main...pgrete/lhlld)
Didn't fix my cloud issues but I should probably nevertheless push this upstream at some point.

@pgrete
Copy link
Contributor

pgrete commented Feb 14, 2023

@BenWibking
Copy link
Contributor Author

BenWibking commented Feb 14, 2023

The main thing complicating this appears to be the addition of a separate ComputeVelocityDifferences kernel.

In Quokka, we found that computing the velocity differences inside the Riemann solver kernel itself improved performance slightly. The code is here, but there is some rather inelegant index manipulation involved: https://github.com/quokka-astro/quokka/blob/4c34ac8fd1299192ef8934b7959eb73f83b27bea/src/hydro_system.hpp#L897. I can probably port this over after the ASU conference.

@BenWibking BenWibking linked a pull request Sep 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants