-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parameterized parse verification #244
Conversation
Codecov Report
@@ Coverage Diff @@
## master #244 +/- ##
=======================================
Coverage 100% 100%
Complexity 1016 1016
=======================================
Files 90 90
Lines 1381 1381
Branches 141 141
=======================================
Hits 1381 1381 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a really good idea to add this check to the standard implementation of ParameterizedParse
! The fact that only the Until
-tests were affected shows that it's something that we should have added a long time ago (or even should have been part of the original implementation).
My only worry is that this change affects the safety net-function of some of the Until
-tests, so we should either make sure that's not the case, or decide on how to proceed.
core/src/test/java/io/parsingdata/metal/token/ParameterizedUntilTest.java
Show resolved
Hide resolved
… stops at the first match. Introduced overload methods with extra argument to indicate what the expected tail is of the stream after parsing the until token.
During development of #241 and #242 this addition helped me a lot to check if the tests were in fact fully parsed. Decided to create a separate pull request for it.
Only had to improve the until tests, since there were 4 tests, that didn't parse until the end. For these tests I decreased the size of the stream.
Also adjusted some other descriptions within the until tests to correctly represent what the tests do.