Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current iteration #242

Merged
merged 26 commits into from
Sep 17, 2018
Merged

Current iteration #242

merged 26 commits into from
Sep 17, 2018

Commits on Jul 2, 2018

  1. #236: Basic, compiling and failing tests for the CurrentIndex ValueEx… 

    …pression.
    @jvdb
    jvdb committed Jul 2, 2018
    Configuration menu
    Copy the full SHA
    e725c68 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2018

  1. #236: Added test for another Token that needs to be included: While.

    @jvdb
    jvdb committed Jul 3, 2018
    Configuration menu
    Copy the full SHA
    e6b2f37 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2018

  1. #236: Basic implementation and tests.

    @jvdb
    jvdb committed Jul 4, 2018
    Configuration menu
    Copy the full SHA
    0e12551 View commit details
    Browse the repository at this point in the history

  2. #236: Added (failing) test for using CurrentIndex in a nested iterable.

    @jvdb
    jvdb committed Jul 4, 2018
    Configuration menu
    Copy the full SHA
    dac4afb View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2018

  1. #236: Improved currentIndex implementation by looking for the deepest… 

    … iterable and counting siblings a long the way.
    @mvanaken
    mvanaken committed Jul 17, 2018
    Configuration menu
    Copy the full SHA
    b449cff View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2018

  1. #236: Renamed CurrentIndex to CurrentIteration to better reflect what… 

    … it represents. Cleaned up test a bit.
    @jvdb
    jvdb committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    a294916 View commit details
    Browse the repository at this point in the history

  2. #236: Fixed one of the CurrentIteration tests.

    @jvdb
    jvdb committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    ec291c2 View commit details
    Browse the repository at this point in the history

  3. #236: Simplified implementation of CurrentIteration, which also impro… 

    …ves coverage.
    @jvdb
    jvdb committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    c3c961e View commit details
    Browse the repository at this point in the history

  4. #236: Improved test coverage for CurrentIteration.

    @jvdb
    jvdb committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    cab9c3e View commit details
    Browse the repository at this point in the history

  5. #236: Converted CurrentIteration to use trampolines for recursion.

    @jvdb
    jvdb committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    3450821 View commit details
    Browse the repository at this point in the history

  6. #236: Added unit test for CurrentIteration.

    @jvdb
    jvdb committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    0d2401b View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2018

  1. #236: Keep track of the last iterable instead of the last iteration a… 

    …nd count the iterations of the iterable afterwards.
    @mvanaken
    mvanaken committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    ad98634 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2018

  1. #236: Small refactorings.

    @jvdb
    jvdb committed Jul 21, 2018
    Configuration menu
    Copy the full SHA
    f8f5034 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2018

  1. #236: Make CurrentIteration return empty value when referencing outsi… 

    …de an iterable scope.
    @mvanaken
    mvanaken committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    a17967c View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2018

  1. #236: More tests. Unfortunately, no way to more precisely check for e… 

    …mpty.
    @jvdb
    jvdb committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    b2961aa View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2018

  1. #236: New implementation for current iteration, which is now tracked … 

    …within ParseState, instead of extracting it out of the ParseGraph. The iteration is now independent on the parse result.
    @mvanaken
    mvanaken committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    6fa43c5 View commit details
    Browse the repository at this point in the history

  2. #236: Removed redundant import.

    @mvanaken
    mvanaken committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    ebfcf71 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2018

  1. #236: Processed review comments of @rdvdijk.

    @mvanaken
    mvanaken committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    6b72849 View commit details
    Browse the repository at this point in the history

  2. #236: Included ToString test for ParseState with iterations.

    @mvanaken
    mvanaken committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    fe71ac2 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2018

  1. #236: Processed review comments from @rdvdijk @ccreeten.

    @mvanaken
    mvanaken committed Sep 3, 2018
    Configuration menu
    Copy the full SHA
    8f9d2c3 View commit details
    Browse the repository at this point in the history

  2. #236: Fixed a failing test.

    @jvdb
    jvdb committed Sep 3, 2018
    Configuration menu
    Copy the full SHA
    97a66c5 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2018

  1. #236: Added test to repair test coverage.

    @jvdb
    jvdb committed Sep 10, 2018
    Configuration menu
    Copy the full SHA
    5442e7a View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2018

  1. 236: Improved CurrentIterationTest.

    @jvdb
    jvdb committed Sep 15, 2018
    Configuration menu
    Copy the full SHA
    93716c3 View commit details
    Browse the repository at this point in the history

  2. 236: Improved CurrentIterationTest to actually verify zero-sized Def … 

    …and CURRENT_ITERATION behaviour inside an IterableToken.
    @jvdb
    jvdb committed Sep 15, 2018
    Configuration menu
    Copy the full SHA
    fd803d8 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2018

  1. #236: Replaced null-check with isEmpty()-call, added newline, improve… 

    …d javadoc. Based on review comments from @rdvdijk and @ccreeten.
    @jvdb
    jvdb committed Sep 16, 2018
    Configuration menu
    Copy the full SHA
    c63f84c View commit details
    Browse the repository at this point in the history

  2. #236: Removed dependency on the javafx Pair class by adding trivial I… 

    …mmutablePair class.
    @jvdb
    jvdb committed Sep 16, 2018
    Configuration menu
    Copy the full SHA
    840c354 View commit details
    Browse the repository at this point in the history