Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor 6 lines occurring 7 times in 7 files: Last.java, First.java, Count.java, UnaryValueExpression.java, FoldCat.java, UnaryLogicalExpression.java, Bytes.java #246

Open
rdvdijk opened this issue Aug 29, 2018 · 1 comment
Assignees
Labels

Comments

@rdvdijk
Copy link
Contributor

rdvdijk commented Aug 29, 2018

I've selected for refactoring 6 lines of code which are duplicated in 7 file(s) (1, 2, 3, 4, 5, 6, 7). Addressing this will make our codebase more maintainable and improve Better Code Hub's Write Code Once guideline rating! 👍

Here's the gist of this guideline:

  • Definition 📖
    Do not copy code.
  • Why
    When code is copied, bugs need to be fixed in multiple places. This is both inefficient and a source of regression bugs.
  • How 🔧
    Avoid duplication by never copy/pasting blocks of code and reduce duplication by extracting shared code, either to a new unit or introduce a superclass if the language permits.

You can find more info about this guideline in Building Maintainable Software. 📖


ℹ️ To know how many other refactoring candidates need addressing to get a guideline compliant, select some by clicking on the 🔲 next to them. The risk profile below the candidates signals (✅) when it's enough! 🏁


Good luck and happy coding! :shipit: ✨ 💯

@rdvdijk rdvdijk added the task label Aug 29, 2018
@rdvdijk rdvdijk added this to the 7.2.0 milestone Aug 29, 2018
@rdvdijk rdvdijk self-assigned this Aug 29, 2018
@rdvdijk
Copy link
Contributor Author

rdvdijk commented Aug 29, 2018

Let's see if we can rename UnaryValueExpression to OneToOneValuExpression and introduce a new OneToManyValueExpression to deduplicate code.

Let's see if we can rename UnaryValueExpression to OneToManyValuExpression and introduce a new OneToOneValueExpression to deduplicate code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants