-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check Validity of Instructions / Buttons #387
Comments
@mrharsh2804 I looked into this and Heroku does not offer an add-on for MongoDB Atlas as replacement for the obsolete mLab add-on. MongoDB Atlas has to be manually set up to work with Heroku. In short, the Heroku button is obsolete and will be removed. |
@dblythy It not just the button / instructions that need to be adapted, I think. It seems the current repo doesn't work out-of-the-box for EB deployment, because in EB the port is assigned automatically, so it's not possible to set the server URL as environment var, because the port is still unknown. A PR for this issue will likely have to address this. Also, when writing the instructions, we should consider that EB can run with or without a load balancer. I think we should focus on the load balancer scenario, because adding TLS to EB without load balancer is not that simple. I think the example repo could actually include a EB definition file that includes all the necessary settings. So all one has to do is execute |
I'll see how I go. I'll crack in this week and comment here for your advice! |
As discussed in this PR, there are a few issues with the current instructions.
As far as I can tell:
-Deploy to AWS button doesn’t work (just creates a new server with “sample code”
-mLab references are obsolete
Assigned to me
The text was updated successfully, but these errors were encountered: