Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse SDK doesn't obey ETag header from express server #1769

Open
4 tasks done
kassiansun opened this issue Jan 4, 2024 · 2 comments
Open
4 tasks done

Parse SDK doesn't obey ETag header from express server #1769

kassiansun opened this issue Jan 4, 2024 · 2 comments
Labels
type:bug Impaired feature or lacking behavior that is likely assumed

Comments

@kassiansun
Copy link

New Issue Checklist

Issue Description

Currently, parse-server will return ETag header for /parse/* requests, but the client is not caching it properly

Steps to reproduce

/parse/config returned ETag header, but the parse client is not sending If-None-Match along with the further requests to /parse/config

Actual Outcome

Expected Outcome

The client should obey the standard HTTP caching semantics, and re-use local cache if the ETag is consistent with remote version: https://www.rfc-editor.org/rfc/rfc9111.html

Environment

Client

  • Parse ObjC SDK version: 2.7

Server

  • Parse Server version: 5.6.0
  • Operating system: Ubuntu 22.04
  • Local or remote host (AWS, Azure, Google Cloud, Heroku, Digital Ocean, etc): AWS

Database

  • System (MongoDB or Postgres): MongoDB
  • Database version: 5.0
  • Local or remote host (MongoDB Atlas, mLab, AWS, Azure, Google Cloud, etc): AWS

Logs

Copy link

Thanks for opening this issue!

  • 🚀 You can help us to fix this issue faster by opening a pull request with a failing test. See our Contribution Guide for how to make a pull request, or read our New Contributor's Guide if this is your first time contributing.

@kassiansun
Copy link
Author

kassiansun commented Jan 4, 2024

Here it says "for security reasons", is this still valid nowadays? The code was introduced at 2015: https://github.com/parse-community/Parse-SDK-iOS-OSX/blob/master/Parse/Parse/Internal/Commands/CommandRunner/URLSession/Session/PFURLSession.m#L261

@mtrezza mtrezza added the type:bug Impaired feature or lacking behavior that is likely assumed label Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Impaired feature or lacking behavior that is likely assumed
Projects
None yet
Development

No branches or pull requests

2 participants