Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Carthage Dependencies #1747

Closed
14 tasks done
dplewis opened this issue Oct 5, 2023 · 3 comments · Fixed by #1754
Closed
14 tasks done

Remove Carthage Dependencies #1747

dplewis opened this issue Oct 5, 2023 · 3 comments · Fixed by #1754
Labels
type:feature New feature or improvement of existing feature

Comments

@dplewis
Copy link
Member

dplewis commented Oct 5, 2023

New Issue Checklist

Issue Description

Although Carthage support has been removed there is a lot of legacy code still in the repo. Carthage supports dynamic frameworks meaning we would have to recompile these dependencies. This can lead to longer build times and significant increases in indexing. We can simply swap them out for their SPM counterparts.

  • Use OCMock static xcframework
  • Use facebook-ios-sdk SPM
  • Use Bolts SPM
  • Use Bolts Swift SPM
  • Use Starstream SPM
  • Remove git submodules
  • Remove Cartfile
  • Remove Scripts/build_third_party.rb
  • Remove any unnecessary .xcodeproj references
  • Remove Carthage install from CI
@parse-github-assistant
Copy link

parse-github-assistant bot commented Oct 5, 2023

Thanks for opening this issue!

  • 🚀 You can help us to fix this issue faster by opening a pull request with a failing test. See our Contribution Guide for how to make a pull request, or read our New Contributor's Guide if this is your first time contributing.

@mtrezza mtrezza added the type:feature New feature or improvement of existing feature label Oct 5, 2023
@mtrezza
Copy link
Member

mtrezza commented Oct 8, 2023

Has this been closed via #1754?

@dplewis
Copy link
Member Author

dplewis commented Oct 18, 2023

Closing via #1763

@dplewis dplewis closed this as completed Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature or improvement of existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants